Normalized CodeBlock return property #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CodeBlock's return property was only set for reference types but not for primitives. This is rather not very consistent and is confusing for people relying on the property to be set.
|
Yea, I've missed it, thanks! |
qmx
added a commit
that referenced
this pull request
Apr 20, 2014
Normalized CodeBlock return property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CodeBlock's return property was only set for reference types but not for primitives. This is rather not very consistent and is confusing for people relying on the property to be set.
There might be some greater meaning to this descision but to me it seemed as if this property was simply forgoten for the primitive return opcodes. At least, this surprised me, so I guess it might surprise others, as well.