Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppport special characters in paths passed as arguments on Windows #28

Closed
kdoroszewicz opened this issue Oct 5, 2015 · 9 comments
Closed
Labels
Milestone

Comments

@kdoroszewicz
Copy link

I've tried running Qnapi with admin privileges and in Windows 8 and Windows 7 compatibility mode. I also turned off Emsisoft Internet Security. Every time just qnapi.exe is lunched but no subtitles are downloaded.

@krzemin
Copy link
Member

krzemin commented Oct 5, 2015

Hi, to clarify your problem, please answer following questions:

  1. Do subtitles for this file download seamlessly after you select it via systray menu -> "Pobierz napisy"?
  2. Or the problem is that after you click an entry in context menu, nothing happens?
  3. Is the problem reproducible for any movie file, or it concern only specific one?
  4. Does the movie file name contains some special characters? Could you provide it?
  5. Which version of QNapi do you use?

@kdoroszewicz
Copy link
Author

  1. Yes, no problem downloading any subtitles via systray option (on any video file).
  2. When I click on the context menu entry, Qnapi in lunched in tray but doesn't download subtitles.
  3. So far the problem affects all of my files (2 .mkv movies, .mp4 tv-series, .avi tv-series).
  4. I renamed the file to "a.mkv" or the tv-series to "a.mp4" and the problem persists.
  5. Qnapi 0.1.9 downloaded from http://qnapi.github.io/ (Windows installer)

@kdoroszewicz kdoroszewicz changed the title Contex menu doesen't download subtitles under Windows 10 Context menu doesn't download subtitles under Windows 10 Oct 5, 2015
@krzemin krzemin added the bug label Oct 6, 2015
@Pietia10
Copy link

Same bug here .

@krzemin
Copy link
Member

krzemin commented Oct 22, 2015

There was such problem on Windows 10 some time ago, described in #9. Please ensure that you have correct registry entries described in that issue.

Another idea: try to uninstall 0.1.9 version and try versions 0.1.8 and 0.1.7 (you can find them here: https://github.com/QNapi/qnapi/releases) to check whether problem is still present?

@kdoroszewicz
Copy link
Author

Reinstalled version 0.1.9 - problem persists.
Installed version 0.1.8 - problem persists.
Installed version 0.1.7 - no context menu.
I've checked registry entries - they look correct "C:\Program Files (x86)\QNapi\qnapi.exe" "%1"
Registry entries are only present in version 0.1.8 and above.

I also tried checking how NapiProjekt handles contex-menu (which works under Windows 10) and after following the same formula QNapi still doesn't download subtitles, it just lunches qnapi.exe.

@Pietia10
Copy link

It fixed itself by restarting windows .:P

@krzemin
Copy link
Member

krzemin commented Oct 23, 2015

Registry entry like that "C:\Program Files (x86)\QNapi\qnapi.exe" "%1" says that qnapi.exe should be executed with single argument - "%1" is replaced with full path of file. In one of the posts before I asked you about special characters in movie file, but it should rather concern full path to a movie file, including directory names. Does it contain some special (i.e. polish diacritic) characters?

What happens when you simply copy you movie file to C:\ directory?

@kdoroszewicz
Copy link
Author

There was "ń" in full path. After copying to path without special characters it works as intended. Now, make qnapi.exe support special characters 😁

@krzemin krzemin added this to the 0.2.0 milestone Oct 23, 2015
@krzemin krzemin changed the title Context menu doesn't download subtitles under Windows 10 Suppport special characters in paths passed as arguments on Windows Oct 23, 2015
@krzemin
Copy link
Member

krzemin commented Oct 24, 2015

Fortunately, I was able to reproduce & fix this bug.
Thanks for reporting and cooperation :)

krzemin added a commit that referenced this issue Nov 24, 2015
…ther app instance is running (at least on Windows)
krzemin added a commit that referenced this issue Dec 12, 2015
…when

another app instance is running (at least on Windows)" as it causes app to
hang at exit

This reverts commit 2f9fff8.
krzemin added a commit that referenced this issue Dec 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants