Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode support #11

Closed
machinehead opened this issue Jul 10, 2014 · 4 comments
Closed

Unicode support #11

machinehead opened this issue Jul 10, 2014 · 4 comments

Comments

@machinehead
Copy link

I've encountered some problems using this library with Russian language. As far as I can see, the problem is in the usage of str's and str literals in code, as well as hardcoding character lists for English. I've managed to make some things work in Py2.7 by adding "from future import unicode_literals" to code and tests, adding Russian to character lists and replacing str to unicode in some places. Maybe I'll come up to a pull request, but in the meantime I'd like to know whether you think it's really needed or you have any ideas on how to implement it the most straightforward way.

@qntm
Copy link
Owner

qntm commented Jul 10, 2014

Have you tried this in Python 3?

Follow-up question, isn't Unicode support a whole different beast between Python 2 and Python 3? I'm okay with supporting both programming languages at once, but if that's about to become impractical then one may need sacrificing.

@pjkundert
Copy link
Contributor

I've used greenery extensively with Unicode, in https://github.com/pjkundert/cpppo. You must use Python3 to gain meaningful Unicode support in greenery, though. There are a host of problems supporting Unicode under Python2.

@machinehead
Copy link
Author

Thank you, I'll try to use it with Python3. I didn't consider this as an option before because I've got a bunch of Python 2.7 code, but now I think I can find a way through.

@qntm
Copy link
Owner

qntm commented Sep 16, 2015

Python 2 support is being dropped in Greenery 3.0.0+ and Unicode support in Python 3 is pretty excellent, so I consider this issue no longer an issue.

@qntm qntm closed this as completed Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants