Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon not show when using font-awesome 4 #145

Open
huynhlbq opened this issue Sep 20, 2018 · 1 comment
Open

Icon not show when using font-awesome 4 #145

huynhlbq opened this issue Sep 20, 2018 · 1 comment

Comments

@huynhlbq
Copy link

Dear,

I saw the missing fa-remove icon in font-awesome version 4, this has been rename to fa-times.
Please update this to support new fa version.

@fott1
Copy link

fott1 commented Oct 22, 2018

A silly but useful for my case workaround was to put $('.fa-remove').removeClass('fa-remove').addClass('fa-times'); on the (click) event of the dom element inline-editor

inline-editor(type="number", [(ngModel)]="price", (onSave)="savePrice($event)", name="editablePrice", size="8", (click)="clickedEditable()")

  clickedEditable() {
    $('.fa-remove').removeClass('fa-remove').addClass('fa-times');
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants