Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Races in QNUserPropertiesManager #443

Open
Ralph1300 opened this issue Feb 6, 2024 · 5 comments
Open

Data Races in QNUserPropertiesManager #443

Ralph1300 opened this issue Feb 6, 2024 · 5 comments

Comments

@Ralph1300
Copy link

We recently experienced some data races in the QNUserPropertiesManager class. We are using Xcode 15 and have the Thread Sanitizer activated for debug builds.

See the attached screenshot for an example. This is usually triggered right after the app start, where we call Qonversion.initWithConfig() from the main thread in the AppDelegate.

As far as I can tell issues are related to

@property (nonatomic, assign, readwrite) BOOL sendingScheduled;
@property (nonatomic, assign, readwrite) BOOL updatingCurrently;

Both properties are read/written to on multiple occasions - sometimes updatingCurrently is wrapped in a synchronization block, but not always. For sendingScheduled this is missing completely.

Stack

Thanks for looking into this, and let me know if you need more input!

@suriksarkisyan
Copy link
Contributor

Hi, @Ralph1300
Thanks for the details. We will look deeper into this issue and come back with an update!

Copy link
Contributor

This issue is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the awaiting answers There is no activity for a while label Feb 14, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 5 days with no activity.

@Ralph1300
Copy link
Author

@suriksarkisyan any news? Issue got closed automatically now.

@SpertsyanKM SpertsyanKM reopened this Feb 19, 2024
@SpertsyanKM SpertsyanKM added investigating and removed awaiting answers There is no activity for a while labels Feb 19, 2024
@suriksarkisyan
Copy link
Contributor

@suriksarkisyan any news? Issue got closed automatically now.

We reopened this issue. It's still in progress. We will try to fix it in the next release. And could you please give me some examples of usage of our properties code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants