Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not able to add space on contenteditable #10130

Closed
paragasu opened this issue Feb 14, 2021 · 3 comments · May be fixed by #10132
Closed

Not able to add space on contenteditable #10130

paragasu opened this issue Feb 14, 2021 · 3 comments · May be fixed by #10132
Assignees
@johnspackman

Comments

@paragasu
Copy link

Describe the bug
qooxdoo somehow disable the event for space. Modern js editor for example quill, editorjs make use of contenteditable
in order for it to work. But since qooxdoo currently seems to be blocking user from key in space character. This editor
not able to work properly

To Reproduce
Here is a minimal playground code to reproduce this problem https://tinyurl.com/y3xbpckt

Expected behavior
Type "Hello", space then "World" should produce "Hello World" but the result is "HelloWorld"

Desktop (please complete the following information):

  • OS: Catalina 10.15.7
  • Browser : firefox, chrome & safari
  • Version latest version
rommni added a commit to rommni/qooxdoo that referenced this issue Feb 15, 2021
@rommni
fix: Allow space in html with contenteditable field
127f1a5 
Add a check before intercept the space event to handle case of contenteditable inside qx.ui.embed.Html()

fix qooxdoo#10130
@rommni rommni mentioned this issue Feb 15, 2021
Open
@level420
Copy link
Member

@paragasu @romni please check this playground sample where I've integrated the quilljs editor:

https://tinyurl.com/yyda8ptu

In this sample there is no problem typing space in the quills editor. I'm useing ckeditor in a similar way and had never any problems tying spaces there.

@level420
Copy link
Member

tested to work on windows 10 with current IE 11, chrome, firefox and on macos 11.2 with current safari, chrome and firefox

@paragasu
Copy link
Author

paragasu commented Feb 17, 2021 •
edited by level420

@paragasu @romni please check this playground sample where I've integrated the quilljs editor:

https://tinyurl.com/yyda8ptu

In this sample there is no problem typing space in the quills editor. I'm useing ckeditor in a similar way and had never any problems typing spaces there.

this is awesome. thank you

@johnspackman johnspackman self-assigned this Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnspackman johnspackman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Allow space in html with contenteditable field rommni/qooxdoo
3 participants
@paragasu @johnspackman @level420