This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Type hints in mailable constructor must be an object #52

Closed

MartijnDB opened this issue Sep 23, 2019 · 6 comments

Labels

bug

MartijnDB commented Sep 23, 2019

In my mailable contructor I have a typehint for int and it fails on that:
"Argument 1 passed to App\Mail\XXX::__construct() must be of the type int, object given"

Qoraiche added the bug label

Owner

Qoraiche commented Sep 23, 2019 •

edited

Hello @MartijnDB,

can please share your mailable, please?

Author

MartijnDB commented Sep 23, 2019

Sure. See the screenshot.

Qoraiche mentioned this issue

Support Integer type hinted paramater ReeceM/mocker#10

Closed

Collaborator

ReeceM commented Sep 23, 2019

@Qoraiche, and @MartijnDB.

I have had a look at it and initially there isn't a way to account for all the PHP builtin types as the __toString magic method allows for one to react to the string type hint.

Things like the int, bool, float types need to be accounted for differently.

I have a working patch on my local fork of the repo, I will clean it up and push it and you can test it as a PR on the main repo here.

Please let me know if this is okay?

Owner

Qoraiche commented Sep 23, 2019

@ReeceM of course, thank you

ReeceM added a commit to ReeceM/laravel-mail-editor that referenced this issue


          fix: type-hint errors applies Qoraiche#52

ReeceM mentioned this issue

Fix/type hints #53

Merged

Qoraiche pushed a commit that referenced this issue


          fix: type-hint errors applies #52

5036fd3

Collaborator

ReeceM commented Sep 28, 2019 •

edited

HI @MartijnDB, release v1.3.2 should have fixed your issue you were experiencing with the mailables. Please do a composer update and reply back if it has fixed it

Qoraiche closed this as completed

Author

MartijnDB commented Sep 30, 2019

Yes. Works as expected. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.