Collectors configuration

[theofidry]

If I understand correctly from the code, Collectors don't have a configuration per se, but rather have access to all the arguments passed to the collector. As a result, they handle those values as they wish without any validation of any kind.

Example:

// src/Collector/ClassNameCollector.php

private function getRegexByConfiguration(array $configuration)
    {
        if (!isset($configuration['regex'])) {
            throw new \LogicException('ClassNameCollector needs the regex configuration.');
        }

        return $configuration['regex'];
    }

Wouldn't it be better to change that and have one configuration per collector? That way we could add a validation step when creating the collector configuration.

[slde-flash]

yes, this is correct.

this will be definitely changed in the near feature when i start working on #76

right now i don't want to promise that a validation step will be possible. i would prefer a "hackable" configuration over static checks, but i'll do my best to reach both goals.