Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to the LightSource class #12

Open
dalonsoa opened this issue Jun 12, 2018 · 2 comments
Open

Small improvements to the LightSource class #12

dalonsoa opened this issue Jun 12, 2018 · 2 comments

Comments

@dalonsoa
Copy link
Collaborator

The LightSource class deals with light sources (the solar spectrum or other spectra) and there are currently two things to improve:

  1. Currently, the "total_power" attribute returns the total power by integrating the spectrum in the requested spectral range. It will be convenient to change it so it provides the power of the total spectrum, even if the wavelength range of interest is much smaller. For example, the "total_power" of the AM1.5g solar spectrum should be 1000 W/m2 even if we ask the spectrum just from 300nm to 900 nm because we are modelling a GaAs solar cell.

  2. The laser light source is defined by a gaussian curve... in wavelength. That does not make sense from a physical point of view it it should be defined as a gaussian curve in energy.

@YunguiLi
Copy link

Regarding the TMM solver to calculate the reflextion of a multilayered ARC, it looks like that the absorption is not included, leading to R+T=100%. It looks like that at least in the example. http://docs.solcore.solar/en/master/Examples/example_RAT_of_ARC.html.
Is it possible to fix this bug?
Thanks a lot!

@phoebe-p
Copy link
Member

@YunguiLi please open a new issue if you have a problem rather than commenting on a (seemingly unrelated?) different issue!

To answer your question, this is not a bug, the TMM solver does calculate absorption. This is a slightly odd example, where the calculated absorption (which will be in the GaInP) is plotted as "Transmission" because we care about transmission into the GaInP. You can see how to get the absorption per layer in for instance this example: Coherency example

@phoebe-p phoebe-p self-assigned this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants