zsh: rework ZSH completion #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The completion for ZSH is upgraded to the new ZSH completion system. To work, the file should be placed somewhere in ZSH fpath to be autoloaded when needed and named `_sub`. There are other embedded misc changes: - `$CURRENT` indicate which word is being autocompleted. - In ZSH, automatic word splitting is disabled in completion. There is no need to quote words.
|
Looks good! |
|
I'm not a ZSH user, but given that @mislav seems to have peer-reviewed this, I recommend merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The completion for ZSH is upgraded to the new ZSH completion
system. To work, the file should be placed somewhere in ZSH fpath to
be autoloaded when needed and named
_sub.There are other embedded misc changes:
$CURRENTindicate which word is being autocompleted.is no need to quote words.
The completion also handles plugins that are able to complete
args. However, most plugins don't and will complete with a subcommand
instead. I don't think there is an universal solution for this.
I am no ZSH wizard. Take this commit with care (works for me).