Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review changes related to Components and WasteStream #47

Closed
yalinli2 opened this issue Jan 19, 2022 · 0 comments
Closed

Review changes related to Components and WasteStream #47

yalinli2 opened this issue Jan 19, 2022 · 0 comments
Assignees

Comments

@yalinli2
Copy link
Member

Hey @joyxyz1994 , I made the updates as we discussed, can you have a look at the commit b47e36c and make updates as you see fit? I added doc and updated tests accordingly.

Note that commit didn't pass the test because I used functions (aliases) that haven't been released in the existing thermosteam, I reverted it in the next commit 8b61f59 and the all tests are passed now

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants