Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript error when starting up program #73

Closed
HeyZeus1232 opened this issue May 4, 2023 · 19 comments
Closed

Javascript error when starting up program #73

HeyZeus1232 opened this issue May 4, 2023 · 19 comments
Labels
bug Something isn't working

Comments

@HeyZeus1232
Copy link

error

this is the error that comes up when i try to start the program.

@Qt-dev
Copy link
Owner

Qt-dev commented May 4, 2023

Which version are you using?

@HeyZeus1232
Copy link
Author

HeyZeus1232 commented May 5, 2023

v1.0.0-alpha.3

I tired both alpha 2 and alpha 4.

v0.3.22 seems to load up fine though.

@Qt-dev
Copy link
Owner

Qt-dev commented May 5, 2023

Oh yeah found the issue. Some error due to old code and new code trying to play well together, sorry about that.
I'll push a bugfix when I make alpha 5

@Qt-dev Qt-dev mentioned this issue May 5, 2023
@Qt-dev Qt-dev added the bug Something isn't working label May 5, 2023
@HeyZeus1232
Copy link
Author

Oh yeah found the issue. Some error due to old code and new code trying to play well together, sorry about that. I'll push a bugfix when I make alpha 5

Hey thanks, just curious, was this not happening to anyone else, and just me? Was this reproducible somehow? Just wondering what the issue is on my end then aswell

@Qt-dev
Copy link
Owner

Qt-dev commented May 6, 2023

I think it was some weird racing conditions of stuff not being setup in the right order. I could definitely force it, but not sure how it ended up happening only to you (as far as I've seen). Maybe that was because you had not done your settings yet? Not sure tbh...

Try it with Alpha.5 and let me know if that still errors

@HeyZeus1232
Copy link
Author

HeyZeus1232 commented May 7, 2023

Error:

Require stack:
- C:\Users\---\AppData\Local\Programs\Exile Diary Reborn\resources\app.asar\build\main\SettingsManager.js
- C:\Users\---\AppData\Local\Programs\Exile Diary Reborn\resources\app.asar\build\main\Responder.js
- C:\Users\---\AppData\Local\Programs\Exile Diary Reborn\resources\app.asar\build\main\index.js
- 
    at Module._resolveFilename (node:internal/modules/cjs/loader:963:15)
    at n._resolveFilename (node:electron/js2c/browser_init:2:109751)
    at Module._load (node:internal/modules/cjs/loader:811:27)
    at f._load (node:electron/js2c/asar_bundle:2:13330)
    at Module.require (node:internal/modules/cjs/loader:1035:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at SettingsManager.<anonymous> (C:\Users\---\AppData\Local\Programs\Exile Diary Reborn\resources\app.asar\build\main\SettingsManager.js:92:41)
    at step (C:\Users\---\AppData\Local\Programs\Exile Diary Reborn\resources\app.asar\build\main\SettingsManager.js:56:23)
    at Object.next (C:\Users\---\AppData\Local\Programs\Exile Diary Reborn\resources\app.asar\build\main\SettingsManager.js:37:53)
    at C:\Users\---\AppData\Local\Programs\Exile Diary Reborn\resources\app.asar\build\main\SettingsManager.js:31:71

OS: Windows NT 10.0.19045

also says `Error: Cannot find module 'C:\Users---\AppData\Roaming\exile-diary\settings.json'

this is the new error that comes up. fresh install, other versions all completely removed before installing alpha 5.

@Qt-dev
Copy link
Owner

Qt-dev commented May 7, 2023

Hmm.... That file does not exist at all, right?

@HeyZeus1232
Copy link
Author

Yeah its not anywhere doesn't seem to be getting created

@Qt-dev
Copy link
Owner

Qt-dev commented May 8, 2023

Hmm I am going to try and run through that same error in the week. In the meantime, can you try adding an empty file to see if it unblocks the whole thing? I would send you one but github does not seem to like sending json files -_-

All you need to do is to create a settings.json file with notepad or whatever, and add this content to it:

{}

@HeyZeus1232
Copy link
Author

So creating the file allows the program to run, but when i press "settings" tab, it comes with this error:

Unexpected Application Error!
Error invoking remote method 'get-characters': Error: Missing poesessid or accountName
Error: Error invoking remote method 'get-characters': Error: Missing poesessid or accountName
at a.invoke (node:electron/js2c/renderer_init:2:7610)

@Qt-dev
Copy link
Owner

Qt-dev commented May 8, 2023

Dang, that's ...
Ok, I see this one, and how to fix it, but I will not do it today.

To unblock it for yourself, you'll need to turn that settings file into :

{
    "accountName": "YOUR_ACCOUNT_NAME",
    "poesessid": "YOUR_POESESSID"
}

Replace the two variables with proper value and you should be good
This should fix it for you for now, while I spend a bit more time figuring out why settings.json creation does not work

@HeyZeus1232
Copy link
Author

HeyZeus1232 commented May 8, 2023

it comes up with another error, and i added this line from the settings json from the stable version.

"activeProfile":{"characterName":"CHAR_NAME_HERE","league":"Crucible"}

The program runs, and i can click the settings tab now, and can change the settings, but it seems all the other tabs are empty (stash, gear etc), i cant run the game at the moment so i cant test it, but i can tomorrow after i finish work.

@Qt-dev
Copy link
Owner

Qt-dev commented May 8, 2023

Oh yeah, the alpha does not have these pages yet. I'm implementing them as fast as I can :)
For now it has the main page, the mods recognition from screenshot, and all the stats in each map

@Qt-dev
Copy link
Owner

Qt-dev commented May 10, 2023

I found the issue and got the fix ready for the next alpha release, FYI.
I am working on adding Oauth instead of Poesessid. That should be doable this week, and the alpha version I make from that will include the fix

@Qt-dev
Copy link
Owner

Qt-dev commented May 13, 2023

alpha 6 should fix all that now. Not only does it include a fix for config stuff, but it also replaces all that poesessid with proper oauth

@Qt-dev
Copy link
Owner

Qt-dev commented May 15, 2023

I'll mark this as in review. If I do not hear from you until tomorrow, I'll consider this resolved with the latest alpha then :)

@Qt-dev Qt-dev added the in review This issue is being reviewed label May 15, 2023
@HeyZeus1232
Copy link
Author

I'll mark this as in review. If I do not hear from you until tomorrow, I'll consider this resolved with the latest alpha then :)

hey, sorry i have not had any time this past week to do anything, I did a complete clean install of alpha 10 and it booted up, But when i logged into POE account it comes up with this:

newerror

@Qt-dev
Copy link
Owner

Qt-dev commented May 16, 2023

No worries hehe. I was just trying to clean up what I thought I fixed :)
There's a couple issues on clean installs, I'll look at that this week. Sorry about that

@Qt-dev Qt-dev removed the in review This issue is being reviewed label May 16, 2023
@Qt-dev
Copy link
Owner

Qt-dev commented May 30, 2023

This should be cleaned up now. I'll close it for now, don't hesitate to reopen it and shout at me if that is not the case :)

@Qt-dev Qt-dev closed this as completed May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants