Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete Down Amplitude Sweeps #8

Closed
ehuegler opened this issue Jul 8, 2022 · 3 comments · Fixed by #32
Closed

Incomplete Down Amplitude Sweeps #8

ehuegler opened this issue Jul 8, 2022 · 3 comments · Fixed by #32
Assignees
Labels
bug Something isn't working

Comments

@ehuegler
Copy link
Collaborator

ehuegler commented Jul 8, 2022

When sweeping amplitude, downward sweeps will not be longer than the previous upward sweep. For example, if you sweep up from 0% to 50%, then try to sweep down from 100% to 25%, the downward sweep you get will only go from 75% to 25.

This seems to be specific to amplitude sweeps; frequency sweeps do not have the same issue.

There also seems to be a related issue that the downward amplitude sweep is triggering before the profile pin goes low. Not sure if that is a separate issue.

@ehuegler ehuegler self-assigned this Jul 8, 2022
@ehuegler ehuegler added the bug Something isn't working label Jul 8, 2022
@ehuegler ehuegler changed the title Shortened Down Sweep Incomplete Down Sweeps Jul 11, 2022
@ehuegler ehuegler changed the title Incomplete Down Sweeps Incomplete Down Amplitude Sweeps Jul 11, 2022
@ehuegler
Copy link
Collaborator Author

amp_sweep_bug

@dihm
Copy link
Contributor

dihm commented Jul 14, 2022

Wow, that is really annoying. Maybe amplitude sweeps aren't actually going to be a fully functioning feature after all. I suppose it is a lower priority, for us at least, than getting frequency sweeps working. This will be doubly true if we get single tone table mode working as well (as a decent fall-back method for amplitude sweeps). With some luck, you should have a decent frequency measurement soon (KJ should be doing that next) then you can ditch amplitude sweeps entirely for the time being.

@ehuegler
Copy link
Collaborator Author

After further testing I have concluded that the solution in #32 definitely should not work, and in some situations it actually does not. If the time steps are set to anything other than a clock cycle then downward sweeps do not happen at all.

That might not be a huge problem though because this means it works for the highest resolution sweeps. It only causes an issue if you try to make a sweep that last over a longer period of time. Will have to decide if that is preferable to not being able to sweep as far as you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants