Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using getVariantMap in C++ models #7

Closed
renom opened this issue May 3, 2017 · 3 comments
Closed

Using getVariantMap in C++ models #7

renom opened this issue May 3, 2017 · 3 comments

Comments

@renom
Copy link

renom commented May 3, 2017

Why getVariantMap method is private in AbstractJsonRestListModel and AbstractXmlRestListModel? I think this method should be declared as protected similarly to getVariantList. The reason is that it can be useful for additional methods in C++ model. For example, calling an additional action of rest api.
@renom renom changed the title getVariantMap in C++ models Using getVariantMap in C++ models May 3, 2017
@kafeg
Copy link
Member

kafeg commented May 3, 2017

Hello!
If you realy need this, please make simple pull request, i will merge it.

Now I can not edit and run tests myself.

@renom
Copy link
Author

renom commented May 4, 2017

PR is already there. Thanks!

@kafeg
Copy link
Member

kafeg commented May 4, 2017

Merged!

@kafeg kafeg closed this as completed May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kafeg @renom