Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidity detects Qtum addresses as having an invalid checksum #237

Open
Earlz opened this issue Jul 20, 2017 · 2 comments
Open

Solidity detects Qtum addresses as having an invalid checksum #237

Earlz opened this issue Jul 20, 2017 · 2 comments
Labels
help wanted P3-NoRush A valid task that would be good to have done, but not at all important

Comments

@Earlz
Copy link
Contributor

Earlz commented Jul 20, 2017

A valid contract address in Qtum is detected as invalid in Solidity and gives a compiler warning. This is most likely due to our different contract (and pubkeyhash) format. I'm not sure there is a workable solution around this, but it should be investigated

browser/Untitled6.sol:19:21: Warning: This looks like an address but has an invalid checksum. If this is not used as an address, please prepend '00'.
            address(0x357b7b1379b0ef2fd7328c28a60456b34a2c618b).send(this.balance / 10000);
@Earlz
Copy link
Contributor Author

Earlz commented Sep 4, 2017

not priority

@Earlz Earlz closed this as completed Sep 4, 2017
@Earlz Earlz reopened this Feb 23, 2018
@Earlz
Copy link
Contributor Author

Earlz commented Jun 1, 2018

This is because Ethereum uses a checksum method where certain characters of the address are capitalized. This should be fairly simple to integrate, but does require changing everywhere that hex addresses are printed or otherwise given to the user.

@Earlz Earlz added P3-NoRush A valid task that would be good to have done, but not at all important help wanted labels Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted P3-NoRush A valid task that would be good to have done, but not at all important
Projects
None yet
Development

No branches or pull requests

1 participant