-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash caught when formting markdown link #159
Comments
Looks like the error happens on this line in the renderer: https://github.com/quackduck/go-term-markdown/blob/v0.14.2/renderer.go#LL310C3-L310C3 Very strange |
Well actually it makes sense right? If you're trying to link something you need to give the link some display text, right? Of course, a panic is the wrong way to respond to this, but also it doesn't crash the server lol. So we have two options, make the renderer return an error or just don't do anything. |
Even with a text, the renderer does not changes the output much. I think the render should just display input text in this case. |
do you mean just the link text? |
I mean if I type |
What should it output? |
I tried to send
[](https://xkcd.com/949/)
and I got:The text was updated successfully, but these errors were encountered: