Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: broken file due to invalid array_output schema #415

Closed
jimniels opened this issue Apr 8, 2023 · 3 comments · Fixed by #561
Closed

bug: broken file due to invalid array_output schema #415

jimniels opened this issue Apr 8, 2023 · 3 comments · Fixed by #561
Assignees
Labels
type: bug something is broken

Comments

@jimniels
Copy link
Collaborator

jimniels commented Apr 8, 2023

Per a comment in the discord, a user created a file and couldn't re-open it the next day.

I got a hold of the file and after importing it locally and having it run the file schema validation, i found the error was coming from this part of the file:

image

array_output is not supposed to allow objects inside of it, so zod was throwing an error when trying to parse and validate it before the app opened it.

image

So i just removed those two empty objects and imported it back into the app and it worked, and i saw this in the spreadsheet

image

@jimniels
Copy link
Collaborator Author

jimniels commented Apr 8, 2023

Original file (renamed from .grid to .txt):

Build_PC.txt

@davidkircos
Copy link
Collaborator

davidkircos commented Apr 8, 2023

Yeah, this is a repeatable issue. Should be an easy enough fix. We just need to clean the data coming back from Python better. Ensure it is always string[] or string[][].

@jimniels jimniels changed the title broken file due to invalid array_output schema bug: broken file due to invalid array_output schema Apr 25, 2023
@jimniels jimniels added the type: bug something is broken label May 17, 2023
@jimniels
Copy link
Collaborator Author

This is a problem for nested arrays too

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants