Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on city links is broken in iOS Firefox #18

Closed
qualitymanifest opened this issue Jan 3, 2020 · 3 comments
Closed

Clicking on city links is broken in iOS Firefox #18

qualitymanifest opened this issue Jan 3, 2020 · 3 comments

Comments

@qualitymanifest
Copy link
Owner

While attempting to navigate the query menu, clicking on a panel will expand the panel but clicking on an item in the panel does not navigate to that link. This only happens on iOS Firefox.

@qualitymanifest
Copy link
Owner Author

Bizarrely, it is also broken when using a mobile device simulator in chromium devtools. When it fails, if you inspect what's going on in parseQueryString, window.location.search is what it should be, but Array.from(queryString) is empty.

If you refresh the page while in full screen mode, then change to the mobile simulator, it works.

If you refresh the page while in the mobile simulator, and then switch to full screen mode, it fails in full screen mode. This is the only way you can get it to fail in full screen mode.

@qualitymanifest
Copy link
Owner Author

qualitymanifest commented Jan 15, 2020

This issue can be duplicated in the console, only when the mobile simulator is open:

let params = new URLSearchParams("?city=PITTSBURGH&state=PA")
console.log(params.get("city")) // this works regardless, so it's not an issue of URLSearchParams not picking up the params
console.log(Array.from(params)) // Works in console w/ desktop, empty on mobile simulator
console.log(...params) // Works in console w/ desktop and mobile simulator, BUT:
// when you try to use it in `parseQueryString` it throws an error!!!
// "Invalid attempt to spread non-iterable instance" which comes from @babel/runtime

So it looks to be an issue with Array.from, but what? I don't think it's an issue of Array.from being overwritten somewhere, because when you console.log it, it still takes you to the native code.

Repeating the above in the console with a different website open works without issue.

@qualitymanifest
Copy link
Owner Author

qualitymanifest commented Jan 15, 2020

Closed in 476d838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant