Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent Go language update has broken dep.go #8

Closed
GoogleCodeExporter opened this issue Mar 22, 2015 · 5 comments
Closed

Recent Go language update has broken dep.go #8

GoogleCodeExporter opened this issue Mar 22, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link
Contributor

What steps will reproduce the problem?
1. Update to latest go source base (I'm at 36cb646b1790 tip)
2. Start goclipse
3. Notice dep.exe does not get created in the .metadata/... directory 

What is the expected output? What do you see instead?
Generate dep.exe from dep.go

What version of the product are you using? On what operating system?
Svn revision 57

Please provide any additional information below.

The number of arguments to ParseFile has been reduced from 4 to 3.
This is the diff that causes the problem:
http://code.google.com/p/go/source/diff?spec=svn168f888ecd8c084459df04933c481d04
570a4d17&r=24a31d895bbd3f6216401b30cd7440bea9d0751b&format=side&path=/src/pkg/go
/parser/interface.go&old_path=/src/pkg/go/parser/interface.go&old=e5b35966e16252
20b15147959b71d63f7a5fe1e2

Is it possible that reflection could be used to handle both signatures?



Attached is a patch to generate an entry in the error log when compilation of 
dep.exe has failed.

Original issue reported on code.google.com by graham.m...@gmail.com on 24 Aug 2010 at 5:35

Attachments:

@GoogleCodeExporter
Copy link
Contributor Author

There seem to be more than the change in parameter list. And it is a show 
stopper :(

I'm taking this issue and do a fix soon.

Thanks for posting and the research.

Original comment by adrian.m...@gmail.com on 30 Sep 2010 at 5:43

  • Added labels: Priority-High
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Contributor Author

ok, commited a few changes. I've tested with gowin32_2010-09-22.zip on windows. 
Should be ok for other platforms too. 

Original comment by adrian.m...@gmail.com on 30 Sep 2010 at 6:43

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Contributor Author

Issue 11 has been merged into this issue.

Original comment by graham.m...@gmail.com on 12 Oct 2010 at 1:19

@GoogleCodeExporter
Copy link
Contributor Author

[deleted comment]

@GoogleCodeExporter
Copy link
Contributor Author

Original comment by emerson....@gmail.com on 15 Oct 2010 at 6:59

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant