Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotating types of data sources #88

Open
nsbgn opened this issue Apr 1, 2022 · 1 comment
Open

Annotating types of data sources #88

nsbgn opened this issue Apr 1, 2022 · 1 comment

Comments

@nsbgn
Copy link
Contributor

nsbgn commented Apr 1, 2022

We want to work with the most specific type possible. However, we deduce the type of data sources from the most general corresponding input type of the tools that process it (cf graph.py#L202). This is not necessarily the most specific type of the data, and so the final output type may not be the most specific, either.

It would be helpful to be able to annotate data sources with their specific type. The only thing that would be needed would be for the library to understand <source node> ta:type <type node> statements in the workflow specification and to instantiate corresponding source expression with the corresponding type.

Deduction via tool specification is still a pretty good method if such annotations aren't available. Note that it's not a problem at all that a data source can be conceptualized in multiple ways (see also issue #87). In this case, there would simply be multiple ta:type predicates on the source, and the tool would pick the one it likes via the standard polymorphic mechanisms.

@nsbgn
Copy link
Contributor Author

nsbgn commented Nov 13, 2022

See commit 2905a4c for where this behaviour should be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant