Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Insight constructor (tag property) #7838

Closed
4 tasks done
Bernd-H opened this issue Mar 7, 2024 · 0 comments · Fixed by #8058
Closed
4 tasks done

Bug in Insight constructor (tag property) #7838

Bernd-H opened this issue Mar 7, 2024 · 0 comments · Fixed by #8058
Assignees
Labels

Comments

@Bernd-H
Copy link

Bernd-H commented Mar 7, 2024

Expected Behavior

Tag property in Insight gets set when passing the tag argument to the following Insight constructor:
Insight(Symbol, TimeSpan, InsightType, InsightDirection, string)

Actual Behavior

SourceModel property gets set instead of Tag.

Potential Solution

Pass arguments correctly to the other Insight constructor:
public Insight(..) : this(symbol, period, type, direction, null, null, null, null, tag) instead of this(symbol, period, type, direction, null, null, tag)

Reproduce Issue

var insight = new Insight(symbol, TimeSpan.Zero, InsightType.Price, InsightDirection.Up, "1");

Checklist

  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
  • I have provided detailed steps to reproduce the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants