Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine punctuation regex #2049

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Redefine punctuation regex #2049

merged 3 commits into from
Feb 17, 2021

Conversation

kbenoit
Copy link
Collaborator

@kbenoit kbenoit commented Feb 12, 2021

Changes the punctuation regex from \\p{P}+ to \\p{P}. Means we correctly recognise as a username @_.

Solves #2048.

@kbenoit kbenoit requested a review from koheiw February 12, 2021 18:53
@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #2049 (19b4af6) into master (f680dcd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2049   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files          70       70           
  Lines        3970     3970           
=======================================
  Hits         3778     3778           
  Misses        192      192           
Impacted Files Coverage Δ
R/tokens.R 99.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 785ac60...de95d8f. Read the comment docs.

@kbenoit kbenoit merged commit 962083a into master Feb 17, 2021
@kbenoit kbenoit deleted the issue-2048 branch February 17, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants