Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid grouping by day when calculating quantile mean returns #88

Closed
luca-s opened this issue Sep 20, 2016 · 1 comment
Closed

Avoid grouping by day when calculating quantile mean returns #88

luca-s opened this issue Sep 20, 2016 · 1 comment

Comments

@luca-s
Copy link
Collaborator

luca-s commented Sep 20, 2016

As alphalens is data frequency agnostic, the aggregation by day performed when calculating quantile mean returns doesn't make sense all the time. It could produce better plots for some scenarios, depending on data frequency and data time span, but not for all the possible data given in input to alphalens.

I am suggesting to remove the aggregation by day or to make it optional and in this latter case the aggregation period should be configurable: minute, day, hour, week, whatever.

Also the feature should be applied to all the plots consistently (not only on some of them). Currently it is applied only to plotting.plot_quantile_returns_violin, plotting.plot_cumulative_returns_by_quantile and plotting.plot_mean_quantile_returns_spread_time_series.

@jameschristopher
Copy link
Contributor

fixed in #89. Thanks Luca!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants