Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded Y axis range in "Forward Return Information Coefficient (IC)" plot #99

Closed
luca-s opened this issue Nov 8, 2016 · 5 comments

Comments

@luca-s
Copy link
Collaborator

luca-s commented Nov 8, 2016

This hard coded range (-0.25, 0.25) can be annoying sometimes.

@jameschristopher
Copy link
Contributor

We could hard code a new range to (-1, 1)

@luca-s
Copy link
Collaborator Author

luca-s commented Nov 8, 2016

Yes or don't hard code anything and let the plot to auto adjusts the axis ranges by itself. But there might be a reason behind those hard coded values ?

@jameschristopher
Copy link
Contributor

My main reasoning was so that you'd be able to visually compare between multiple graphs. If the axes are different that becomes much harder

@luca-s
Copy link
Collaborator Author

luca-s commented Nov 9, 2016

That's actually a good reason. So hard coding the range (-1,1) is the way to go...or we could get the maximum Y axis range amongst all the plots and subsequently set that as Y range for all the plots.

@jameschristopher
Copy link
Contributor

jameschristopher commented Nov 10, 2016

Andrew and I had talked about doing a max/min range initially and never came back to it for some reason. Sounds good! Fixed in #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants