-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hard coded Y axis range in "Forward Return Information Coefficient (IC)" plot #99
Comments
We could hard code a new range to (-1, 1) |
Yes or don't hard code anything and let the plot to auto adjusts the axis ranges by itself. But there might be a reason behind those hard coded values ? |
My main reasoning was so that you'd be able to visually compare between multiple graphs. If the axes are different that becomes much harder |
That's actually a good reason. So hard coding the range (-1,1) is the way to go...or we could get the maximum Y axis range amongst all the plots and subsequently set that as Y range for all the plots. |
Andrew and I had talked about doing a max/min range initially and never came back to it for some reason. Sounds good! Fixed in #100 |
This hard coded range (-0.25, 0.25) can be annoying sometimes.
The text was updated successfully, but these errors were encountered: