Fix for pandas 1.0 #124
Merged
Fix for pandas 1.0 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py 1.4.x - kept a python 2.7 with the last supported versions of pydata.
* as_matrix was deprecated then removed. to_numpy() works in this situation * updated travis to include pandas 1.0.x, python 3.7 numpy 1.18 and scipy 1.4.x * kept a python 2.7 build with the last supported versions of pydata. * versions compatible with conda for travis
|
Thanks for taking this on! Unfortunately due to being tied to zipline we need to maintain compat with their pandas requirements which are older (currently |
|
Hey - we could bridge the gap with a try: except: block - try to_numpy() first, then to_matrix() if that fails. Shall I do that? Then the older tests should pass as well. |
|
here it is - I left a comment in the code to explain too. |
|
Thanks! |
|
My pleasure. Any chance we could push a release so I can use as a dependency? |
|
@richafrank I tagged a new release but couldn't upload to pypi due to permissions. Could you do that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXED for Pandas >= 1.0.0
as_matrix() was deprecated then removed. to_numpy() works in this situation
updated travis to include pandas 1.0.x, python 3.7 numpy 1.18 and scipy 1.4.x
kept a python 2.7 build with the last supported versions of pydata.