Documentation and bundles fixes #2763
Conversation
Newer sphinx optionally depends on it.
instead of using the first heading in the README
_run already does this.
Also for clean Updated the beginner's tutorial
zipline/data/bundles/core.py
Outdated
| (before is not None and dt < before) or | ||
| (after is not None and dt > after) | ||
| (before is None or dt < before) and | ||
| (after is None or dt > after) |
There was a problem hiding this comment.
@llllllllll What is the intended way to clean out all the ingestions for a bundle? I tried with no args, but nothing happened. However, my change looks to fail the relevant test...
There was a problem hiding this comment.
You need to pass either --before, --after or --keep-last to specify which ingests you would like to delete.
There was a problem hiding this comment.
Ah, ok, that was my confusion. I expected that passing none of them would delete everything.
zipline/data/bundles/core.py
Outdated
| (before is not None and dt < before) or | ||
| (after is not None and dt > after) | ||
| (before is None or dt < before) and | ||
| (after is None or dt > after) |
There was a problem hiding this comment.
why invert all of these conditions?
There was a problem hiding this comment.
This was my attempt to fix the noop clean commands (when I passed no args). I'll instead raise BadClean in that case.
| @@ -72,7 +72,7 @@ | |||
| # Add any paths that contain custom static files (such as style sheets) here, | |||
| # relative to this directory. They are copied after the builtin static files, | |||
| # so a file named "default.css" will overwrite the builtin "default.css". | |||
| html_static_path = ['.static'] | |||
| html_static_path = [] | |||
There was a problem hiding this comment.
do we not have any images or anything?
There was a problem hiding this comment.
Not there at least. We have 2 pngs in docs/tutorial_files.
Running Sphinx v3.1.2
making output directory... done
WARNING: html_static_path entry '.static' does not exist
| @@ -317,13 +320,6 @@ def run(ctx, | |||
| benchmark_spec=benchmark_spec, | |||
| ) | |||
|
|
|||
| if output == '-': | |||
There was a problem hiding this comment.
why can we remove this logic?
There was a problem hiding this comment.
The final lines of _run (called above) are:
if output == '-':
click.echo(str(perf))
elif output != os.devnull: # make the zipline magic not write any data
perf.to_pickle(output)
return perf
| @@ -112,6 +112,9 @@ def _(*args, **kwargs): | |||
| return d | |||
|
|
|||
|
|
|||
| DEFAULT_BUNDLE = 'quantopian-quandl' | |||
richafrank
force-pushed
the
whats-up-doc
branch
from
0144b1e
to
81597da
Compare
| @@ -578,6 +578,9 @@ def clean(name, | |||
| if e.errno != errno.ENOENT: | |||
| raise | |||
| raise UnknownBundle(name) | |||
|
|
|||
| if before is after is keep_last is None: | |||
richafrank
force-pushed
the
whats-up-doc
branch
from
81597da
to
1c561b5
Compare
richafrank
force-pushed
the
whats-up-doc
branch
from
1c561b5
to
b2640da
Compare
Before:
After:
Before:
After:
