Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign the FeatureExtractor and FeatureCollector interaction #9

Open
patacca opened this issue Jun 20, 2023 · 0 comments
Open

Redesign the FeatureExtractor and FeatureCollector interaction #9

patacca opened this issue Jun 20, 2023 · 0 comments
Labels
high High priority refactoring Refactoring part of the code

Comments

@patacca
Copy link
Collaborator

patacca commented Jun 20, 2023

Ideally a FeatureExtractor should return the feature instead of adding it to FeatureCollector passed as a parameter.
The visitor should then add the returned feature to the collector
@patacca patacca added high High priority refactoring Refactoring part of the code labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high High priority refactoring Refactoring part of the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patacca