Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandon using Jaeger internal API to trace requests #779

Open
michalvavrik opened this issue May 11, 2023 · 0 comments
Open

Abandon using Jaeger internal API to trace requests #779

michalvavrik opened this issue May 11, 2023 · 0 comments
Labels
priority/moderate higher priority than low but lower then high

Comments

@michalvavrik
Copy link
Contributor

michalvavrik commented May 11, 2023

All our tests with Jaeger are using tracer URL

to retrieve traces, that is port 16686 - HTTP JSON internal that only serve for Jaeger UI and is (theoretically) unstable. More importantly, that's not a way customers are going to retrieve traces and we are basically cheating (= my personal and highly subjective opinion). We should use gRPC/Protobuf which will be challenging in OCP scenarios.

We should implement API for traces retrieval on JaegerService so that each test don't do it on their own and we have logic that retrieves these traces at one place. Ideally, this logic uses gRPC protobuf on baremetal and maybe remain with HTTP internal till we resolve OCP issues.

Ad OCP gRPC protobuf - I think if we want to use gRPC protobuf with OCP, we will need to deal with HTTP2 routes and SSL certificates and have trusted certificate or somehow get our self-signed certificates to get trusted.

@michalvavrik michalvavrik added the priority/moderate higher priority than low but lower then high label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/moderate higher priority than low but lower then high
Projects
None yet
Development

No branches or pull requests

1 participant