Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom settings file is not reflected in the tests #943

Open
rsvoboda opened this issue Nov 2, 2023 · 1 comment
Open

Custom settings file is not reflected in the tests #943

rsvoboda opened this issue Nov 2, 2023 · 1 comment
Labels
priority/low lowest priority

Comments

@rsvoboda
Copy link
Member

rsvoboda commented Nov 2, 2023

Both test framework and test suite GH Actions CI uses .github/mvn-settings.xml.

But the tests that run mvn command do not reflect that settings. These executions rely on settings file in the default location.

CC @mjurc @michalvavrik wdyt about support for custom settings file for the tests based maven invocation?
The same could apply for custom maven.repo.local. But on the other hand, this would be probably just Maven specific.

@michalvavrik
Copy link
Contributor

But the tests that run mvn command do not reflect that settings. These executions rely on settings file in the default location.

It would allow us to stop copying settings to ~/.m2 as we do in Jenkins jobs, right? +1

The same could apply for custom maven.repo.local. But on the other hand, this would be probably just Maven specific.

TBH I thought system properties are already propagated, so I'd expect maven.repo.local to work already. Probably wrong now that I read your description.

@michalvavrik michalvavrik added the priority/low lowest priority label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low lowest priority
Projects
None yet
Development

No branches or pull requests

2 participants