Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform SpringDiTest by exposing endpoints that provides information injected to test #1181

Closed
michalvavrik opened this issue Apr 18, 2023 · 0 comments · Fixed by #1315
Closed

Transform SpringDiTest by exposing endpoints that provides information injected to test #1181

michalvavrik opened this issue Apr 18, 2023 · 0 comments · Fixed by #1315
Assignees
@linartova
Labels
good first issue Good for newcomers priority/high Issue of high severity that does not block next product release.

Comments

@michalvavrik
Copy link
Contributor

We use @QuarkusTest here

quarkus-test-suite/spring/spring-data/src/test/java/io/quarkus/ts/spring/data/di/SpringDiTest.java

Line 20 in c2b235a

// Not converted into @QuarkusScenario, because invoking jakarta.enterprise.inject.spi.CDI / io.quarkus.arc.Arc is not supported.

as we can't access right instance of CDI.current() in QuarkusScenario. However we can expose endpoints that provides same information. It should be copy & paste to endpoints and current test methods will just call these endpoint. When this is done, replace @QuarkusTest with @QuarkusScenario.
@michalvavrik michalvavrik added good first issue Good for newcomers priority/low Minor issue. labels Apr 18, 2023
@michalvavrik michalvavrik mentioned this issue Apr 18, 2023
Closed
@michalvavrik michalvavrik added priority/high Issue of high severity that does not block next product release. and removed priority/low Minor issue. labels Apr 18, 2023
@michalvavrik michalvavrik changed the title Transform SpringDiTest by exposing endpoints that provides information injected to test` Transform SpringDiTest by exposing endpoints that provides information injected to test Apr 29, 2023
@linartova linartova mentioned this issue Jul 12, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linartova linartova

Labels
good first issue Good for newcomers priority/high Issue of high severity that does not block next product release.
Projects
None yet
Milestone
No milestone
2 participants
@michalvavrik @linartova