Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban com.google.code.findbugs:jsr305 unconditionally #95

Closed
ppalaga opened this issue Nov 24, 2021 · 3 comments
Closed

Ban com.google.code.findbugs:jsr305 unconditionally #95

ppalaga opened this issue Nov 24, 2021 · 3 comments

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Nov 24, 2021

com.google.code.findbugs:jsr305 a pure dev UX dependency that might be useful when compiling code containing those annotations, but is completely useless when it is only a transitive dependency.
We exclude it where we can in Camel Quarkus, but we still need to fix some holes.
I guess it would be useful to ban it on the platform level so that no participant can smuggle it in.

Related: https://issues.redhat.com/browse/QUARKUS-1461

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 25, 2021

While this is doable for Camel Quarkus apache/camel-quarkus#3337 , it is not that straightforward for Quarkus: findbugs is required not only to compile quarkus-grpc, but also it is required by user apps when the grpc codegen does its work.

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 25, 2021

So findbugs definitely needs to stay managed by Quarkus.

I just found out that it is managed in quarkus-build-parent rather then quarkus-bom. I think quarkus-bom would be a better place to manage it so that the alignment is effective also for the platform and thus for all user apps.

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 25, 2021

I have sent quarkusio/quarkus#21716 closing this one.

@ppalaga ppalaga closed this as completed Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant