Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Kafka tests in rest-fights to use new KafkaCompanion #37

Closed
edeandrea opened this issue Mar 8, 2022 · 0 comments · Fixed by #57
Closed

Update Kafka tests in rest-fights to use new KafkaCompanion #37

edeandrea opened this issue Mar 8, 2022 · 0 comments · Fixed by #57
Labels
enhancement New feature or request fights-service Fights service

Comments

@edeandrea
Copy link
Collaborator

edeandrea commented Mar 8, 2022 •
edited

Coming in Quarkus 2.8 is the new KafkaCompanion. This will allow the rest-fights app to remove the custom KafkaConsumerResource class and InjectKafkaConsumer annotation. The FightResourceIT tests can just use the new KafkaCompanion.

See #58 for a similar enhancement on the event-statistics service.
@edeandrea edeandrea added enhancement New feature or request fights-service Fights service event-stats-service Event statistics service labels Mar 8, 2022
agoncal referenced this issue in agoncal/quarkus-super-heroes Apr 4, 2022
@github-actions
Generate deploy resources (from Create deploy resources #37)
ddf18fd
@edeandrea edeandrea mentioned this issue Apr 14, 2022
Closed
@edeandrea edeandrea changed the title Update Kafka tests in rest-fights & event-statistics to use new KafkaCompanion Update Kafka tests in rest-fights to use new KafkaCompanion Apr 14, 2022
@edeandrea edeandrea removed the event-stats-service Event statistics service label Apr 14, 2022
@edeandrea edeandrea mentioned this issue Apr 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request fights-service Fights service
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use KafkaCompanion test resource for rest-fights test ozangunalp/quarkus-super-heroes
1 participant
@edeandrea