Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Java 21 #376

Open
edeandrea opened this issue Oct 6, 2023 · 8 comments · May be fixed by #434
Open

Introduce Java 21 #376

edeandrea opened this issue Oct 6, 2023 · 8 comments · May be fixed by #434
Assignees
Labels
Automation Automation enhancement New feature or request event-stats-service Event statistics service fights-service Fights service heroes-service Heroes service narration-service Narration service ui UI app villains-service Villains service

Comments

@edeandrea
Copy link
Collaborator

Now that Java 21 is out, run all of the automation & produce Java 17 & 21 images for all the apps.

One note is that the Mandrel builder image doesn't yet have a Java 21 image, so for now we'll have to use the GraalVM CE builder image

@edeandrea edeandrea added the enhancement New feature or request label Oct 6, 2023
@edeandrea edeandrea self-assigned this Oct 6, 2023
@edeandrea edeandrea added fights-service Fights service villains-service Villains service heroes-service Heroes service event-stats-service Event statistics service ui UI app Automation Automation narration-service Narration service labels Oct 6, 2023
@edeandrea
Copy link
Collaborator Author

@cescoffier With this we will publish both a JVM Java 17 & 21 container image for each app. Should we do the same with native? Or just a "latest" native (Java 21)?

When we were doing both Java 11 & 17 we did both for JVM images but only did a 17 native. I'm thinking we continue with this pattern.

Thoughts?

@cescoffier
Copy link
Member

cescoffier commented Oct 6, 2023 via email

@edeandrea
Copy link
Collaborator Author

edeandrea commented Oct 6, 2023

Well for now for native I would switch to use quay.io/quarkus/ubi-quarkus-graalvmce-builder-image:jdk-21

@cescoffier
Copy link
Member

cescoffier commented Oct 6, 2023 via email

@edeandrea
Copy link
Collaborator Author

Right. I get that.

What about building a container image for jvm on 21? There is no openjdk-21 image on registry.access.redhat.com. For now maybe I'll try to build my own on ubi-minimal.

@cescoffier
Copy link
Member

cescoffier commented Oct 6, 2023 via email

@edeandrea
Copy link
Collaborator Author

This is what I'm going with for now...

FROM azul/zulu-openjdk:21-jre
RUN mkdir -p /deployments/lib && \
    mkdir -p /deployments/app && \
    mkdir -p /deployments/quarkus

ENV LANG='en_US.UTF-8' LANGUAGE='en_US:en'

# We make four distinct layers so if there are application changes the library layers can be re-used
COPY target/quarkus-app/lib/ /deployments/lib/
COPY target/quarkus-app/*.jar /deployments/
COPY target/quarkus-app/app/ /deployments/app/
COPY target/quarkus-app/quarkus/ /deployments/quarkus/

EXPOSE 8087

ENTRYPOINT ["java", "-jar", "/deployments/quarkus-run.jar", "-Dquarkus.http.host=0.0.0.0", "-Djava.util.logging.manager=org.jboss.logmanager.LogManager"]

edeandrea added a commit to edeandrea/quarkus-super-heroes that referenced this issue Oct 6, 2023
edeandrea added a commit to edeandrea/quarkus-super-heroes that referenced this issue Nov 1, 2023
edeandrea added a commit to edeandrea/quarkus-super-heroes that referenced this issue Nov 1, 2023
edeandrea added a commit to edeandrea/quarkus-super-heroes that referenced this issue Nov 2, 2023
edeandrea added a commit to edeandrea/quarkus-super-heroes that referenced this issue Nov 2, 2023
@edeandrea
Copy link
Collaborator Author

Hey @cescoffier now that https://catalog.redhat.com/software/containers/ubi9/openjdk-21-runtime/6501ce769a0d86945c422d5f, quay.io/quarkus/ubi-quarkus-mandrel-builder-image:jdk-21, and https://github.com/graalvm/mandrel/releases/tag/mandrel-23.1.1.0-Final are all out, do you think we should switch the superheroes to ONLY have Java 21?

Or should we have deployments for both 17 & 21, like we used to do for 11 & 17. We would only use 21 for native - I'm thinking just on the JVM side.

I'm almost to the point of saying forget about 17, just go fully to 21.

@holly-cummins / @agoncal / @cescoffier WDYT?

@edeandrea edeandrea linked a pull request Nov 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation Automation enhancement New feature or request event-stats-service Event statistics service fights-service Fights service heroes-service Heroes service narration-service Narration service ui UI app villains-service Villains service
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants