Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narration endpoint is missing a fallback, and shouldn't be there if the narration service isn't up #435

Open
holly-cummins opened this issue Nov 17, 2023 · 1 comment

Comments

@holly-cummins
Copy link
Collaborator

I'm seeing two problems with the narration button:

  • In all cases, we show it after the fight result comes in. If a workshop has been configured to not do narration – or early in the workshop – do we want the button to be there at all? Keeping the UI simpler seems ideal, so maybe we should put some sort of guard on whether we show the button. The complexity is it would normally have to be something the fight service would tell us, and we don't want people to have to code a guard for a thing they're not doing! So we'd need to think of a nice ui-only mechanism.
  • There should be a fallback for when the service is missing, but when I click the button, I get this in the UI:
image

This is the backend error:

16:55:46 ERROR [io.qu.ve.ht.ru.QuarkusErrorHandler] (executor-thread-3) HTTP Request to /api/fights/narrate failed, error id: ae33f1c8-bd78-4bed-b6c4-5acb42b859fc-1: jakarta.ws.rs.ProcessingException: io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/127.0.0.1:8086
        at org.jboss.resteasy.reactive.client.handlers.ClientSendRequestHandler$2.accept(ClientSendRequestHandler.java:199)
        at org.jboss.resteasy.reactive.client.handlers.ClientSendRequestHandler$2.accept(ClientSendRequestHandler.java:191)
        at io.smallrye.context.impl.wrappers.SlowContextualConsumer.accept(SlowContextualConsumer.java:21)
        at io.smallrye.mutiny.helpers.UniCallbackSubscriber.onFailure(UniCallbackSubscriber.java:62)
        at io.smallrye.mutiny.operators.uni.UniOperatorProcessor.onFailure(UniOperatorProcessor.java:55)
        at org.jboss.resteasy.reactive.client.AsyncResultUni.lambda$subscribe$1(AsyncResultUni.java:37)
@holly-cummins
Copy link
Collaborator Author

Thinking about it more, I think maybe we have a fallback in the narration service, but not in the fight service. That's reasonable, since we want to keep things simple - but it makes hiding the button more important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant