-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace default height
for "banner image" in grid listing by max-height
#2999
Comments
I think that this item is likely more specifically creating a new type of listing layout that permits flexible grid sized (per the attached conversation). Moving to 1.4 |
Can I please ask if there's a follow up to this? I seem to have a problem that I think is related to this on this site; images are rescaled but the aspect ratio is not respected. As you make the screen smaller, then 2 things happen:
|
I think switching to But, this has the effect of reducing the alignment of items within the grid, as titles and other data are in different spots, which I don't think we want in our default grid layout. Instead, perhaps you could consider changing the number of columns using |
As discussed initially in the discussion. |
Thanks both. I can look into this more closely, but I guess using masonry would basically amount to hacking the complied html files to add the relevant bits (including potentially a java script)? |
Discussed in #2990
Originally posted by mcanouil October 23, 2022
Hi,
currently, the grid listing has a default height of 150px for top image in the card which causes the image to be "cropped" in nearly all situations.
Instead, I would suggest to not set
height
property butmax-height
to allow responsive scaling of the image without cropping the image.For example, on the left, manually defined max-height, while on the right it's the default from the grid listing.
A video to show the resizing issue of setting
height
.resizing.mov
The text was updated successfully, but these errors were encountered: