-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedding Vimeo video does not work with "unlisted" links #5390
Comments
@allenmanning are vimeo videos supposed to be supported by our own Lua filter or by video.js integration ? I am still unsure about this and this is not the first time I am asking myself this question. I am wondering because currently with both example above, I believe video.js will be used because there is no quarto-cli/src/resources/extensions/quarto/video/video.lua Lines 118 to 119 in 4a4e9f1
Videojs builder will then be used, but it is unclear to me what we package for this because vimeo is supposed to be surported with a plugin Anyhow, you know the feature the best. |
@Joda66 Thanks for posting this bug. I'd like to learn more about how these links have changed. When I ran a local test I see that the share link seems to be the same as before: When I check the docs, I'm seeing the same pattern This other pattern we can consider supporting, I'm curious to learn more about how it is being generated. |
This is a good point as it seems we could use VideoJS for this. I think that we want to use the vendor snippets like we do for YouTube as this really seems to be more the expected behaviour. We could consider adding support for VideoJS if there seems like there is a real demand for this. VideoJS is the fall-back if we don't recognize the URL as being mapped to an existing vendor snippet. |
Note sure if I was clear in my previous post. Sorry if it was, but I prefer to be sure. Currently using this syntax (which is the share link without https:// part)
will not be recognized and it will fallback to videojs I believe. (I think it did in my test).
I would have expected Doing this will correctly not use videojs
Shouldn't we improve that and also match when no |
Thanks, @allenmanning, for your response. I´m selecting "Hide from Vimeo" and also disable sharing for my videos, as I want only a group of selected students to work on those. This worked fine in the past, I copied the generated link not from the sharing icon you show in your screenshot, but from the sharing button in the dialog where I can customize the settings. A few days ago Vimeo changed something here and is informing the user, the "hide from Vimeo" will be depreciated. When I create a new video an prepare it for sharing, the "Hide from Vimeo"-Option has been replaced by the "Unlisted" option an the created links show the new pattern: Thanks for looking into the topic. |
For reference: Articles about the change : https://help.vimeo.com/hc/en-us/articles/13808733889425 Possibly related security change ongoing: https://help.vimeo.com/hc/en-us/articles/13741122177169 I see no example of the link in the part about sharing private video So hard to share about this specific change of the link. What they say though:
So I wonder if the link is the correct one to embed. |
Thanks, @cderv for your reply! The link I get when klicking on the link-icon is A workaround (that is also recommended for wordpress in the article you provided) is embedding html. This works fine with the code, that vimeo is providing, but obviously, it is not the solution we are looking for. |
So this link seems better, isn't it ? does it work with the video shortcode ?
The video shortcode is supposed to write this specific HTML code for you based on the link you are passing to the shortcode. |
Thx @cderv for your reply. It is strange, rendering resulted in the "No video source specified for video shortcode" - error yesterday a this morning, but not it renders without complaints. However, the video is not displayed. In the screenshot I tried shortcode (results in video not found), html-embedding (this works) and publishing a video via shortcode that is not unlisted. This works also. So I assume, the problem could be the "privacy key" (I have underlined it in blue) which is added to links for unlisted videos? |
Possibly related to privacy hash yes. FWIW the link Possibly related to
It is possibly that for unlisted video, one need to use the specific url with If this url Our vimeo builder is here quarto-cli/src/resources/extensions/quarto/video/video.lua Lines 115 to 134 in 07931d0
and we build the iframe by inserting the video link to src. If you use video shortcode with the same url as you have in embed test then it should work. So it seems some special treatment needs to be done for unlisted video - but can we know for sure this is unlisted ? Is this @allenmanning proposal: I think we should try to handle this Found this article to comfort the choice https://www.denisbouquet.com/vimeo-url-2-strings-unlisted-hash-videos-with-2-ids/ |
The link which does not work for you is fine at my account, because I'm logged in to Vimeo. Thanks a lot for this idea. |
Just realized, that Vimeo has rolled back its update to the privacy settings: The hide-from-vimeo-option generates links without privacy hashes. However, the Unlisted-Option still requires dealing with the privacy hash. |
Apologies, I have read through the thread again and I'm not clear as to the current proposed change. Can you please provide clear Steps to Reproduce following a template like this: Bug Template Description:Embedding Vimeo video does not work with "new" links. Steps to Reproduce:
Expected Result:Video snippet is created with the URL ... Actual Result:Video snippet isn't created and it falls-back to Video JS. |
With the following steps, Vimeo produces a link, that does not work with the Quarto shortcode {{ video }}: When logged in with my Standard Account. The link copied to the clipboard is in my example Expected Result: Actual Result: Solution / Workaround Please note: the privacy setting "Hide from Vimeo", that creates links for embedding only, does not (!) contain a privacy hash and works well with the shortcode: |
This makes good sense, thank you. I think it is ready for dev now. |
Description
Unlisted Vimeo videos produce a link that does not work with the Quarto shortcode {{ video }}
Steps to Reproduce
https://vimeo.com/800138810/fdcc90d662?share=copy
{{< video https://vimeo.com/800138810/fdcc90d662?share=copy >}}
Expected Result:
A video snippet is created with the url. The video snippet can load the video.
Actual Result:
Using this link with the shortcode results in the error message "Invalid embedding-code"
Workaround
Replace the slash in the privacy hash with
"?h="
and delete"?share=copy"
so{{< video https://vimeo.com/800138810?h=fdcc90d662 >}}
Please note: the privacy setting "Hide from Vimeo", that creates links for embedding only, does not (!) contain a privacy hash and works well with the shortcode
{{< video https://vimeo.com/800139587?share=copy >}}
so no problem for "Hide-from-Vimeo" videos as of writing this post, but only for "Unlisted" videos.The text was updated successfully, but these errors were encountered: