-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotly image does not render correctly when rendering with GH actions #5766
Comments
(Just adding some information) The error appears to be coming from the fact that |
There's definitely something funky happening on compile. It looks like the output went to the terminal stdout rather than being captured on the notebook: https://github.com/juliasilge/plotly-quarto-ghpages/actions/runs/5092338378/jobs/9153655952 |
@cscheid you tagged Jupyter, but I believe this is knitr related. This document has a R chunk so even with python chunk,
Really interesting ! Thanks for catching this. I think this could come from some recent changes in knitr regarding progress bar that seems related. @juliasilge you could try updating to pin knitr 1.41 and see if this is still happening ? 1.42 is the version with the progress bar change. |
The "real" example where we saw this problem also had both R and Python in the document: https://github.com/rstudio/vetiver.rstudio.com/blob/main/learn-more/metrics-metadata.qmd |
@juliasilge would it be possible to pin knitr 1.41 and see if it fixes the CI building ? |
It looks like it does not. I installed knitr 1.41 and added session info so you can see that: |
Thank you. Then it is possibly not knitr. This is really weird issue. I need to find where (and which tool) is doing the cat()-ing of the dependency string into the wrong place. Some configuration or tool. I'll try to debug that. Possibly related to reticulate as this is a python chunk output. Thank you for building the repo for testing |
Hi, We also encountered this on an 1.4 prerelease https://github.com/computorg/computo-quarto-extension Regards |
@fradav We need a complete reproducible example from you in order to be able to help. |
(@cderv please feel free to change the milestone. I'm just making sure we have no issues that are not assigned anywhere) |
Sorry for the delay. To be noted:
|
@fradav can you share link to log of a deployement ? We noticed in other OP example that some output were not sent in the right place... I would like to check the knitting log output from the rendering. |
The main github action log:
|
Thanks a lot. Nothing indeed. Though now I noticed that both example happens with Python code chunk using plotly inside .qmd document run with knitr engine. This shows several layers of possible problem
I think looking into knitr + reticulate would be a way to see if this is related to how dependencies are generated and handled. I'll try to find time to investigate that based on the two examples. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Just cross referencing for future me as it could be related : |
Bug description
When using Plotly with Quarto on GH pages, the plot does not render.
Steps to reproduce
I made a small repo to demonstrate the problem:
Expected behavior
When I publish with GH pages, I expect the image to be rendered on this page: https://juliasilge.github.io/plotly-quarto-ghpages/
Actual behavior
There is a blank space where the image should be. I can write the HTML to a file and then include that, but that is not as expected.
Your environment
This happens when publishing on GH pages, like so: https://github.com/juliasilge/plotly-quarto-ghpages/blob/main/.github/workflows/quarto-publish.yaml
The page looks fine if I render locally.
Quarto check output
You can look at the GH action workflow to see which versions of Quarto and such are being used.
The text was updated successfully, but these errors were encountered: