Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo actions in book proj not visible in mobile view #5818

Closed
blacksqr opened this issue Jun 5, 2023 · 2 comments
Closed

Repo actions in book proj not visible in mobile view #5818

blacksqr opened this issue Jun 5, 2023 · 2 comments
Assignees
Labels
books bug Something isn't working triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone.
Milestone

Comments

@blacksqr
Copy link

blacksqr commented Jun 5, 2023

Bug description

In a book project with repo actions defined, if a chapter has a TOC, the repo action icon will not appear in the footer if the page is displayed in mobile view.

Chapters without a TOC will display the icon as expected.

Steps to reproduce

Create a book project:

$ quarto create-project mybook --type book
$ quarto preview mybook

Edit _quarto.yml so it appears as follows:

project:
  type: book

book:
  title: "mybook"
  author: "Norah Jones"
  date: "6/5/2023"
  repo-url: "https://github.com/quarto-dev/quarto-web/"
  repo-actions: [source]
  chapters:
    - index.qmd
    - intro.qmd
    - summary.qmd
    - references.qmd

bibliography: references.bib

format:
  html:
    theme: cosmo
  pdf:
    documentclass: scrreprt

When the project re-renders and I navigate the the Preface page, the github "View Source" icon is visible in the TOC.

Switch to mobile view in the newly rendered project (ctrl-shift-m for Firefox)

Expected behavior

On the Preface page, I expect to see the github icon with "View Source" label in the footer when in mobile view.

Actual behavior

The github icon on the Preface page is missing. It appears in the footer on all the other chapter pages in mobile view, because they don't have a TOC.

Your environment

  • Quarto version 1.4.122
  • OS: Kubuntu 20.04

Quarto check output

[✓] Checking versions of quarto binary dependencies...
      Pandoc version 3.1.2: OK
      Dart Sass version 1.55.0: OK
      Deno version 1.33.2: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
      Version: 1.4.122
      Path: /opt/quarto/bin

[✓] Checking basic markdown render....OK

[✓] Checking Python 3 installation....OK
      Version: 3.8.10
      Path: /usr/bin/python3
      Jupyter: (None)

      Jupyter is not available in this Python installation.
      Install with python3 -m pip install jupyter

      There is an unactivated Python environment in systemd-private-90e163f7653b4f69ae913301b284ec8a-systemd-resolved.service-YMBMlh. Did you forget to activate it?

[✓] Checking R installation...........OK
      Version: 4.2.1
      Path: /usr/lib/R
      LibPaths:
        - /usr/local/lib/R/site-library
        - /usr/lib/R/site-library
        - /usr/lib/R/library
      knitr: 1.37
      rmarkdown: 2.11

[✓] Checking Knitr engine render......OK
@blacksqr blacksqr added the bug Something isn't working label Jun 5, 2023
@mcanouil
Copy link
Collaborator

mcanouil commented Jun 5, 2023

Thank you for the report!
Could you additionally add some screenshots to ensure we understand this right?

@mcanouil mcanouil added the books label Jun 5, 2023
@blacksqr
Copy link
Author

blacksqr commented Jun 5, 2023

Preface page. No github icon in footer:

Screenshot 2023-06-05 at 11-41-53 mybook

Introduction page. Github icon in footer:

Screenshot 2023-06-05 at 11-43-09 mybook - 1 Introduction

@cscheid cscheid added the triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone. label Jun 7, 2023
@dragonstyle dragonstyle added this to the v1.4 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
books bug Something isn't working triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone.
Projects
None yet
Development

No branches or pull requests

4 participants