Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code annotation on hover always introduces a slider #7056

Closed
snhansen opened this issue Sep 28, 2023 · 6 comments
Closed

Code annotation on hover always introduces a slider #7056

snhansen opened this issue Sep 28, 2023 · 6 comments
Assignees
Labels
bug Something isn't working themes Related to HTML theming or any other style related issue (like highlight-style) windows
Milestone

Comments

@snhansen
Copy link

snhansen commented Sep 28, 2023

Bug description

When using the code-annotations: hover option, the annotation box has an unusable slider in the bottom of the text box. I suspect this isn't intended as it has been introduced in newer versions (wasn't the case in e.g. 1.4.309).

ss1

Steps to reproduce

---
format: 
  html:
    code-annotations: hover
---

```{r}
x <- 1 # <1>
```
1. Annotation.

Expected behavior

No response

Actual behavior

No response

Your environment

Windows 11.

Quarto check output

Quarto 1.4.388
[>] Checking Quarto installation......OK
      Version: 1.4.388
      Path: C:\Users\au234616\AppData\Local\Programs\Quarto\bin
      CodePage: 1252
@snhansen snhansen added the bug Something isn't working label Sep 28, 2023
@mcanouil

This comment was marked as resolved.

@mcanouil mcanouil added the needs-repro Issues that are blocked until reporter provides an adequate reproduction label Sep 28, 2023
@snhansen

This comment was marked as resolved.

@mcanouil

This comment was marked as resolved.

@mcanouil mcanouil added the triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone. label Sep 28, 2023
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the stale Issues open for 30+ days without providing a "working" reproducible example label Oct 13, 2023
@cderv cderv removed needs-repro Issues that are blocked until reporter provides an adequate reproduction stale Issues open for 30+ days without providing a "working" reproducible example triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone. labels Oct 13, 2023
@cderv
Copy link
Collaborator

cderv commented Oct 13, 2023

@dragonstyle you added the scroll at 8301889

.tippy-content {
  overflow-x: scroll;
}

Would that be ok to use auto instead of scroll to show the slider only when this is needed ?

Or maybe it was not possible because of some other box sizing reason. 🤔

Mac difference with others OS seems to be a known issue, and auto is the recommended way: https://kilianvalkhof.com/2021/css-html/you-want-overflow-auto-not-overflow-scroll/

Thanks !

BTW, it seems that content has break-words because even a very long string does not get overflow

---
format: 
  html:
    code-annotations: hover
---

```{r}
x <- 1 # <1>
1 + x # <2>
```
1. Annotation.
2. VERY VERY VERY VERY VERY VERY VERY VERY LONG ANNOTATION

image

@cderv cderv added this to the v1.4 milestone Oct 13, 2023
@cderv cderv added the themes Related to HTML theming or any other style related issue (like highlight-style) label Oct 13, 2023
@snhansen
Copy link
Author

Just wanted to add this is not only for code annotations but more generally for any cross-ref hover (equations, figures, sections, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working themes Related to HTML theming or any other style related issue (like highlight-style) windows
Projects
None yet
Development

No branches or pull requests

4 participants