Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarto update does not removed out-dated files #7375

Closed
ALanguillaume opened this issue Oct 27, 2023 · 0 comments
Closed

quarto update does not removed out-dated files #7375

ALanguillaume opened this issue Oct 27, 2023 · 0 comments
Assignees
Labels
bug Something isn't working extensions relates to Quarto extensions mechanism triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone.
Milestone

Comments

@ALanguillaume
Copy link

ALanguillaume commented Oct 27, 2023

Bug description

When updating a quarto extension, quarto update does not delete out-dated files.

Considering this extension https://github.com/ThinkR-open/quakr/ as a reprex

The tmp branch contains one exta files coucou.truc compare to main

tmp

Screenshot from 2023-10-27 10-44-07

main

Screenshot from 2023-10-27 10-44-15

Steps to reproduce

Create a quarto project and add extension thinkr-open/quakr using the version from branch tmp

mkdir -p quarto-bug
cd quarto-bug/
quarto create-project
quarto add thinkr-open/quakr@tmp --no-prompt

As expected the file coucou.truc is present in the extension folder

$ ls _extensions/thinkr-open/thinkridentity/
background.png  coucou.truc  _extension.yml  logo.png  logo.svg  thinkridentity.scss

Now updating the extension switching to main. Mimicking the suppression of the file coucou.truc

quarto update thinkr-open/quakr --no-prompt

Expected behavior

The extension is updated and correspond to the version on main.

coucou.truc should be deleted.

$ ls _extensions/thinkr-open/thinkridentity/
background.png   _extension.yml  logo.png  logo.svg  thinkridentity.scss

Actual behavior

The extension is updated but the file coucou.truc is NOT deleted and remains in the extension directory.

$ ls _extensions/thinkr-open/thinkridentity/
background.png  coucou.truc  _extension.yml  logo.png  logo.svg  thinkridentity.scss

Your environment

OS: Ubuntu Jammy 22.04 LTS

Quarto check output

[✓] Checking versions of quarto binary dependencies...
      Pandoc version 3.1.1: OK
      Dart Sass version 1.55.0: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
      Version: 1.3.361
      Path: /opt/quarto/bin

[✓] Checking basic markdown render....OK

[✓] Checking Python 3 installation....OK
      Version: 3.10.12
      Path: /usr/bin/python3
      Jupyter: 4.11.1
      Kernels: python3

(/) Checking Jupyter engine render....Traceback (most recent call last):
  File "/opt/quarto/share/jupyter/jupyter.py", line 21, in <module>
    from notebook import notebook_execute, RestartKernel
  File "/opt/quarto/share/jupyter/notebook.py", line 17, in <module>
    import nbformat
ModuleNotFoundError: No module named 'nbformat'
[✓] Checking Jupyter engine render....OK

@ALanguillaume ALanguillaume added the bug Something isn't working label Oct 27, 2023
@cscheid cscheid added the triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone. label Oct 27, 2023
@cderv cderv added the extensions relates to Quarto extensions mechanism label Oct 30, 2023
@dragonstyle dragonstyle added this to the v1.4 milestone Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working extensions relates to Quarto extensions mechanism triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone.
Projects
None yet
Development

No branches or pull requests

4 participants