Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$navbar-bg no longer defaulting to $primary in v1.4.455 #7447

Closed
EllaKaye opened this issue Nov 2, 2023 · 0 comments
Closed

$navbar-bg no longer defaulting to $primary in v1.4.455 #7447

EllaKaye opened this issue Nov 2, 2023 · 0 comments
Assignees
Labels
bug Something isn't working html Issues with HTML and related web technology (html/css/scss) themes Related to HTML theming or any other style related issue (like highlight-style) triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone.
Milestone

Comments

@EllaKaye
Copy link

EllaKaye commented Nov 2, 2023

Bug description

The $navbar-bg colour no longer defaults to $primary in the pre-release (v1.4.455). This behaviour is different than in the current release, where it does default to $primary.

I'm not sure if this is a bug or a deliberate design decision change. The documentation still states that $navbar-bg should default to $primary, though the documentation is of course for the current release not the pre-release. If it is a deliberate change, I don't see it listed on the pre-release notes (unless I'm missing something).

Steps to reproduce

See https://github.com/EllaKaye/navbar-bug and the corresponding site at https://ellakaye.github.io/navbar-bug/.

This is created by starting a new Quarto website project within RStudio, then adding a custom.scss file with

/*-- scss:defaults --*/
$aubergine: #552D62;
$primary:   $aubergine !default;

and linking to it appropriately in _quarto.yml:

format:
  html:
    theme: [cosmo, custom.scss]

Expected behavior

The navbar should default to the primary colour (aubergine).

Explicitly adding $navbar-bg: $primary; does change the colour.

Actual behavior

The navbar remains the default colour for the cosmo theme, not the custom theme. If I remove cosmo from the theme listing, the navbar defaults to blue (also not in custom.scss!)

The link colour on the site is $primary, so the theme is getting picked up elsewhere.

Your environment

  • IDE: RStudio 2023.09.1+494
  • MacOS: Ventura 13.6

Quarto check output

Quarto 1.4.455
[✓] Checking versions of quarto binary dependencies...
      Pandoc version 3.1.8: OK
      Dart Sass version 1.55.0: OK
      Deno version 1.33.4: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
      Version: 1.4.455
      Path: /Applications/quarto/bin

[✓] Checking tools....................OK
      TinyTeX: v2022.11
      Chromium: (not installed)

[✓] Checking LaTeX....................OK
      Using: TinyTex
      Path: /Users/u2175871/Library/TinyTeX/bin/universal-darwin
      Version: 2022

[✓] Checking basic markdown render....OK

[✓] Checking Python 3 installation....OK
      Version: 3.9.6
      Path: /Library/Developer/CommandLineTools/usr/bin/python3
      Jupyter: (None)

      Jupyter is not available in this Python installation.
      Install with python3 -m pip install jupyter

[✓] Checking R installation...........OK
      Version: 4.3.1
      Path: /Library/Frameworks/R.framework/Versions/4.3-arm64/Resources
      LibPaths:
        - /Users/u2175871/Library/R/arm64/4.3/library
        - /Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/library
      knitr: 1.43
      rmarkdown: 2.22

[✓] Checking Knitr engine render......OK
@EllaKaye EllaKaye added the bug Something isn't working label Nov 2, 2023
@mcanouil mcanouil added triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone. html Issues with HTML and related web technology (html/css/scss) themes Related to HTML theming or any other style related issue (like highlight-style) labels Nov 2, 2023
@dragonstyle dragonstyle added this to the v1.4 milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working html Issues with HTML and related web technology (html/css/scss) themes Related to HTML theming or any other style related issue (like highlight-style) triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone.
Projects
None yet
Development

No branches or pull requests

3 participants