-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
theme toggle now outside of collapsed menu on small screens (in Quarto 1.4) #8830
Comments
I've reviewed the code and this is by design in Quarto 1.4. We currently place any
I hope this explains our thinking a bit - if you believe this should be changed, it would helpful to hear your thinking and we can think about making an enhancement... |
Thank you for the clarification and explanation. It seems to me that for the average website, your reasons make sense, but there are cases where the current design has disadvantages. A couple of thoughts:
Ideally, the user would have a choice over where to place the tools. |
This makes sense- I'll re-open this as an enhancement and see what we can do! |
(Thanks for sharing the details and example! Any chance you can share a link to that staging page screenshotted above? It would be useful, but not essential, if I could tinker with that a bit in the browser dev tools to formulate a bit of a game plan) |
Thanks for considering this. The site has not officially launched because we're working on improving content but I can share the staging site on the down-low. |
Discussed in #8813
Originally posted by timothoms February 21, 2024
Description
The position of the dark/light theme toggle in relation to the navbar menu has changed in the move from Quarto 1.3 to 1.4. As a result, the theme toggle is now placed outside of the "hamburger" menu (compare the screen shots below, repo here).
Is there a way to include the theme toggle inside the collapsed "hamburger" menu, the way it was in Quarto 1.3?
The text was updated successfully, but these errors were encountered: