Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: about links given external link icons #8977

Closed
aronatkins opened this issue Mar 4, 2024 · 2 comments
Closed

blog: about links given external link icons #8977

aronatkins opened this issue Mar 4, 2024 · 2 comments
Assignees
Labels
bug Something isn't working websites Issues creating websites
Milestone

Comments

@aronatkins
Copy link
Contributor

Bug description

External link icons are given to navigation links within an about page template.

Steps to reproduce

quarto create project blog --no-open about-icon
cd about-icon
echo "    link-external-icon: true" >> _quarto.yml
echo "    link-external-newwindow: true" >> _quarto.yml
quarto render

Expected behavior

The "about" page does not contain icons for external links, as they are provided as navigation for that page.

image

Actual behavior

The "about" page contains icons for external links.

image

Additionally, the generated markup includes the about links outside the <main>..</main> but before the "main" closing comment. Not sure if this positioning is related.

<!-- main -->
<div class="quarto-about-jolla content">
  <img src="profile.jpg" class="about-image
  round " style="height: 15em; width: 15em;">
 <header id="title-block-header" class="quarto-title-block default">
<div class="quarto-title">
<h1 class="title">About</h1>
</div>
<div class="quarto-title-meta">
  </div>
</header><main class="content" id="quarto-document-content">
<p>About this blog</p>


</main>
  <hr class="about-sep">
   <div class="about-links">
  <a href="https://twitter.com" class="about-link" rel="" target="">
    <i class="bi bi-twitter"></i>
     <span class="about-link-text">Twitter</span>
  </a>
  <a href="https://linkedin.com" class="about-link" rel="" target="">
    <i class="bi bi-linkedin"></i>
     <span class="about-link-text">LinkedIn</span>
  </a>
  <a href="https://github.com" class="about-link" rel="" target="">
    <i class="bi bi-github"></i>
     <span class="about-link-text">Github</span>
  </a>
</div>
</div>
 <!-- /main -->

Your environment

No response

Quarto check output

Quarto 1.4.549
[✓] Checking versions of quarto binary dependencies...
      Pandoc version 3.1.11: OK
      Dart Sass version 1.69.5: OK
      Deno version 1.37.2: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
      Version: 1.4.549
      Path: /Applications/quarto/bin

[✓] Checking tools....................OK
      TinyTeX: (external install)
      Chromium: (not installed)

[✓] Checking LaTeX....................OK
      Using: TinyTex
      Path: /Users/aron/Library/TinyTeX/bin/universal-darwin
      Version: 2022

[✓] Checking basic markdown render....OK

[✓] Checking Python 3 installation....OK
      Version: 3.11.7
      Path: /usr/local/opt/python@3.11/bin/python3.11
      Jupyter: (None)

      Jupyter is not available in this Python installation.
      Install with python3 -m pip install jupyter

[✓] Checking R installation...........OK
      Version: 4.3.1
      Path: /Library/Frameworks/R.framework/Resources
      LibPaths:
        - /Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library
      knitr: 1.45
      rmarkdown: 2.25

[✓] Checking Knitr engine render......OK
@aronatkins aronatkins added the bug Something isn't working label Mar 4, 2024
@mcanouil mcanouil added the websites Issues creating websites label Mar 4, 2024
@aronatkins
Copy link
Contributor Author

Workaround: Add the following to the about.qmd YAML block, suppressing links on this page (leaving it elsewhere). Not appropriate if there is lots of supporting text and outbound links in the body text.

format:
  html:
    link-external-icon: false
    link-external-newwindow: false

@cscheid cscheid self-assigned this Mar 5, 2024
@cscheid
Copy link
Collaborator

cscheid commented Mar 5, 2024

Thanks, @dragonstyle! :D

@mcanouil mcanouil added this to the v1.5 milestone Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working websites Issues creating websites
Projects
None yet
Development

No branches or pull requests

3 participants