Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarto_add_extension() ignores user's installation disapproval #172

Closed
eveyp opened this issue Apr 17, 2024 · 1 comment
Closed

quarto_add_extension() ignores user's installation disapproval #172

eveyp opened this issue Apr 17, 2024 · 1 comment

Comments

@eveyp
Copy link

eveyp commented Apr 17, 2024

I'm finding that quarto_add_extension() always installs the extension, even if the user responds with 'n' at the approval prompt:

> quarto::quarto_add_extension("schochastics/quarto-sketchy-html")
Quarto extensions may execute code when documents are rendered.
• If you do not trust the author(s) of this Quarto extensions, we recommend that you
  do not install or use this Quarto extensions.
Do you trust the authors of this Quarto extensions (Y/n)? n
Quarto extensions not installed.
[>] Downloading
[>] Unzipping
    Found 1 extension.

The following changes will be made:
Sketchy HTML documents   [Install]   1.1.0 (format)

[>] Extension installation complete.
Learn more about this extension at https://www.github.com/schochastics/quarto-sketchy-html

It seems like the internal check_extension_approval() function returns FALSE but that doesn't stop the rest of the installation code.

@cderv
Copy link
Collaborator

cderv commented Apr 26, 2024

Thank you - indeed bad issue. Thanks for the report !

@cderv cderv closed this as completed in 9275b2d Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants