New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support job services in OSGi framework with JobStoreTX and JobStoreCMT #37
Conversation
SinaTadayon
commented
Jul 17, 2016
Motivation: Support OSGi job services when job store set to JobStoreTX/JobStoreCMT Modifications: Create org.quartz.osgi package that contains follow features: - Initialize Quartz bundle with Activator - Tracking register/unregister of job services - Provide ClassLoaderHelper that can load classes of job services from other bundles Modify org.quartz.simpl.CascadingClassLoadHelper.java: - Add BundleClassLoaderHelper to end of loaders list Modify quartz-core/pom.xml: - Add Bundle-Activator tag - Modify Private-Package Add .gitignore file that to ignore IDE files and etc. Result: The Quratz support job schedule when OSGi job services configured with JobStoreTX/JobStoreCMT
Hi all, I don't have enough knowledge to test this PR in OSGI env from my machine. Can someone from the quartz dev group help verify this PR? Also, please remove .gitignore as part of the PR because we already have the correct one set in master now. Also please ensure same valid changes is apply to quartz-2.2.x branch. Thanks! |
hi Zemian I test it this project with quartz-2.2.x into my project and it's work. I will remove .gitignore file |
Motivation: Support OSGi job services when job store set to JobStoreTX/JobStoreCMT Modifications: Create org.quartz.osgi package that contains follow features: - Initialize Quartz bundle with Activator - Tracking register/unregister of job services - Provide ClassLoaderHelper that can load classes of job services from other bundles Modify org.quartz.simpl.CascadingClassLoadHelper.java: - Add BundleClassLoaderHelper to end of loaders list Modify quartz-core/pom.xml: - Add Bundle-Activator tag - Modify Private-Package Add .gitignore file that to ignore IDE files and etc. Result: The Quratz support job schedule when OSGi job services configured with JobStoreTX/JobStoreCMT
Hi @SinaTadayon , This contribution falls under the conditions described under the heading "Contributions which do require a full Contributor’s License Agreement (CLA)" here: http://www.quartz-scheduler.org/community/contribute.html We very much appreciate your contribution, and request that you submit a signed agreement. |
Without CLA in the next day or two, this PR will have to be removed from the 2.3.0 milestone |
Dear jhouserizer
Excuse me for delay to answer
I read the contribution agreement and i agree it.
I attached it.
Beat Regards
S.T
Terracota Contribution_20170406200226748.pdf
<https://drive.google.com/file/d/0B5s4Dzg2PgcSMkwteEFLVDRpeURCY0VhZGFNdXZxUURfbF84/view?usp=drive_web>
…On Thu, Apr 6, 2017 at 4:37 AM, jhouserizer ***@***.***> wrote:
Without CLA in the next day or two, this PR will have to be removed from
the 2.3.0 milestone
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMrFtHciXDOMpxCwSXhGmp2Kp1pAvVaTks5rtCywgaJpZM4JOJB8>
.
|
Thank you. Could you also either: 1) update the PR wil the .gitignore file removed, or 2) give me permission to commit/push to your branch. |
Lack of support job services in OSGi framework when job store set to JobStoreTX/JobStoreCMT Modifications: Create org.quartz.osgi package that contains follow features: - Initialize Quartz bundle with Activator - Tracking register/unregister of job services - Provide ClassLoaderHelper that can load classes of job services from other bundles Modify org.quartz.simpl.CascadingClassLoadHelper.java: - Add BundleClassLoaderHelper to end of loaders list Modify quartz-core/pom.xml: - Add Bundle-Activator tag - Modify Private-Package Result: The Quartz support job schedule when OSGi job services configured with JobStoreTX/JobStoreCMT
I solved the conflict, change the commit profile and update the pom file. thx |
Thanks, I will try to review soon. Also, I haven't been able to access that file in your google drive - I sent a couple requests for access - please note them in your google inbox. |
Excuse me,
i send it.
Please check it.
Thanks
…On Wed, Apr 12, 2017 at 6:38 AM, jhouserizer ***@***.***> wrote:
Thanks, I will try to review soon. Also, I haven't been able to access
that file in your google drive - I sent a couple requests for access -
please note them in your google inbox.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMrFtFZCO8FyrhtU4HGCx97EBlOeGfawks5rvDI5gaJpZM4JOJB8>
.
|
I'm not sure we want the changes to CascadingClassLoadHelper that are currently included in this PR. I believe it will make all quartz users dependent upon the osgi libraries. Perhaps an improvement would be to create a new ClassLoadHelper for use by those who are actually using osgi. |
The OSGI libraries are arbitrary which does not forced quartz users dependent to the osgi. Thx |
I will go ahead and merge this, then refactor it some so that the core CascadingClassLoadHelper is not altered, and osgi users can specify a specific class load helper with the existing configuration property "org.quartz.scheduler.classLoadHelper.class". |
Thank you. |
Thank you and Best Regards |