Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QTimeScroller prop 'min-time' and 'max-time' no affect #2

Closed
bjbk opened this issue May 11, 2019 · 8 comments
Closed

QTimeScroller prop 'min-time' and 'max-time' no affect #2

bjbk opened this issue May 11, 2019 · 8 comments

Comments

@bjbk
Copy link

bjbk commented May 11, 2019

I am probably implementing this wrong.

ISSUE: Adding min-time or max-time with string has no effect on scroller
Example (other props left off for brevity)

<q-time-scroller v-model="time" min-time="08:00" max-time="15:30" />

Binding them to a data object has the same result:
:min-time="timeString"
timeString: '08:00'

Example markup for the image shown:

<q-input color="orange-6" filled v-model="time2" label="Enter time" mask="##:##">
            <template v-slot:append>
              <q-icon name="far fa-clock" class="cursor-pointer">
                <q-popup-proxy v-model="showTimeScroller2">
                  <q-time-scroller
                    v-model="time2"
                    :locale="locale"
                    :rounded-borders="roundedBorders"
                    :no-header="false"
                    :no-footer="false"
                    :disable="disable"
                    bar-color="#21ba45"
                    min-time="08:00"
                    max-time="15:30"
                    color="white"
                    background-color="grey-9"
                    inner-color="grey-9"
                    inner-background-color="white"
                    :style="scrollerPopupStyle120"
                    @close="() => { showTimeScroller2 = false }"
                  />
                </q-popup-proxy>
              </q-icon>
            </template>
          </q-input>

Screen Shot 2019-05-10 at 8 46 00 PM

@hawkeye64
Copy link
Member

Yes, sorry. Not implemented yet. I see I filled it out in the Docs. I'll add TBD on them until it's finished.

@bjbk
Copy link
Author

bjbk commented May 11, 2019

No problem! I was just trying it out. I forked the repo, if I can contribute even in a small way, I'll send some PR's. Thanks for a great project!

@hawkeye64
Copy link
Member

hawkeye64 commented May 11, 2019

Having some help would be great, but coordinate with me if you want to make changes. Since I am actively creating this, I may have already added the new functionality or fix already.
It'd be fine to work on min-time/max-time as this is last on my list. I added the properties to remind me to get it done.

@bjbk
Copy link
Author

bjbk commented May 11, 2019

Understood! No hurry on my account. ;)

@bjbk
Copy link
Author

bjbk commented Oct 10, 2019

@hawkeye64 just checking in to see if this will eventually be implemented. Cheers!

@hawkeye64
Copy link
Member

@bjbk I am in the process of rewriting QScroller. Expect some big changes.

@hawkeye64
Copy link
Member

ok, so the rewrite is done, but there is no longer a min/max time
I will be adding this in a future release

@hawkeye64
Copy link
Member

closing this as a new ticket should be created to request this functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants