Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue warn when using the router inside of a Pinia store #12936

Closed
Bosphoramus opened this issue Mar 25, 2022 · 1 comment
Closed

Vue warn when using the router inside of a Pinia store #12936

Bosphoramus opened this issue Mar 25, 2022 · 1 comment
Labels

Comments

@Bosphoramus
Copy link
Contributor

What happened?

Since @quasar/app-webpack version 3.4.3 we get a Vue Warn when using the router from Pinia stores, this is the warn: [Vue warn]: Avoid app logic that relies on enumerating keys on a component instance. The keys will be empty in production mode to avoid performance overhead.

This is caused because the router we provide to the store in the default boot file is not wrapped by Vue's markRaw()

This is documented on Pinia's docs as we can see here

What did you expect to happen?

Everything works, at leas on dev mode, but id spect it to work without warnings on the console.

Reproduction URL

No

How to reproduce?

Try to use the router with this.router inside of a pinia store on @quasar/app-webpack version 3.4.3 - 3.4.5 and check the console.

Flavour

Quasar CLI with Webpack (@quasar/cli | @quasar/app-webpack)

Areas

SPA Mode

Platforms/Browsers

No response

Quasar info output

No response

Relevant log output

No response

Additional context

No response

@rstoenescu
Copy link
Member

Fix will be available in q/app-vite 1.0.0-beta.9 and q/app-webpack v3.4.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants