Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

q/app-vite: Report when lint error/warning has been fixed #13013

Closed
rstoenescu opened this issue Mar 31, 2022 Discussed in #12982 · 4 comments
Closed

q/app-vite: Report when lint error/warning has been fixed #13013

rstoenescu opened this issue Mar 31, 2022 Discussed in #12982 · 4 comments

Comments

@rstoenescu
Copy link
Member

Discussed in #12982

Originally posted by jdheeter March 30, 2022
During development while running the Vite Dev server it's normal for the dev server to pick up some invalid code and throw an error like vite] Internal server error: Transform failed with 1 error:

The problem is that after the error is resolved, there is no feedback in the dev server log. When using webpack it's very obvious when the dev server has refreshed and is now serving correctly or still stuck on an error.

While the Vite dev server is working correctly, it's not always obvious from a developers perspective, because the errors are not followed by any success messages in the logs.

@rstoenescu
Copy link
Member Author

Will be available in q/app-vite beta.12

@maggie44
Copy link
Contributor

It would be nice to have an indicator when the dev environment is up and the 'open browser' setting is set to false.

When open browser automatically is set to true:

 .d88888b.
d88P" "Y88b
888     888
888     888 888  888  8888b.  .d8888b   8888b.  888d888
888     888 888  888     "88b 88K          "88b 888P"
888 Y8b 888 888  888 .d888888 "Y8888b. .d888888 888
Y88b.Y8b88P Y88b 888 888  888      X88 888  888 888
 "Y888888"   "Y88888 "Y888888  88888P' "Y888888 888
       Y8b


 » Reported at............ 16/04/2022 23:22:50
 » App dir................ /Users/arranmagee/Documents/GitHub.nosync/balena-device-ui/ui
 » App URL................ http://localhost:9000/
                           http://192.168.0.36:9000/
 » Dev mode............... spa
 » Pkg quasar............. v2.6.6
 » Pkg @quasar/app-vite... v1.0.0-beta.14
 » Browser target......... es2019|edge88|firefox78|chrome87|safari13.1

 App • Opening default browser at http://localhost:9000/

When open browser is set to false:

 .d88888b.
d88P" "Y88b
888     888
888     888 888  888  8888b.  .d8888b   8888b.  888d888
888     888 888  888     "88b 88K          "88b 888P"
888 Y8b 888 888  888 .d888888 "Y8888b. .d888888 888
Y88b.Y8b88P Y88b 888 888  888      X88 888  888 888
 "Y888888"   "Y88888 "Y888888  88888P' "Y888888 888
       Y8b


 » Reported at............ 16/04/2022 23:20:52
 » App dir................ /Users/arranmagee/Documents/GitHub.nosync/balena-device-ui/ui
 » App URL................ http://localhost:9000/
                           http://192.168.0.36:9000/
 » Dev mode............... spa
 » Pkg quasar............. v2.6.6
 » Pkg @quasar/app-vite... v1.0.0-beta.14
 » Browser target......... es2019|edge88|firefox78|chrome87|safari13.1

Would be good to have something on the bottom of the second one:

App • Running at http://localhost:9000/

@rstoenescu
Copy link
Member Author

What's wrong with App URL in the banner there?

@maggie44
Copy link
Contributor

maggie44 commented Apr 22, 2022

When open browser is set to false it looks like this:

 .d88888b.
d88P" "Y88b
888     888
888     888 888  888  8888b.  .d8888b   8888b.  888d888
888     888 888  888     "88b 88K          "88b 888P"
888 Y8b 888 888  888 .d888888 "Y8888b. .d888888 888
Y88b.Y8b88P Y88b 888 888  888      X88 888  888 888
 "Y888888"   "Y88888 "Y888888  88888P' "Y888888 888
       Y8b


 » Reported at............ 16/04/2022 23:20:52
 » App dir................ /Users/arranmagee/Documents/GitHub.nosync/balena-device-ui/ui
 » App URL................ http://localhost:9000/
                           http://192.168.0.36:9000/
 » Dev mode............... spa
 » Pkg quasar............. v2.6.6
 » Pkg @quasar/app-vite... v1.0.0-beta.14
 » Browser target......... es2019|edge88|firefox78|chrome87|safari13.1

It could do with clearer indication it is loaded and ready. The pattern in other states is App • .... Making it uniform would have made more sense to me that it is ready, and not still loading. It's not a question of providing the information, more a question of clear indication when it is loaded.

Even App • Ready.. would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants