fix(ui/QTable): Use correct definition for @request's filter #14345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Anyone who was misled by the API docs(code examples were correct) and has passed a function instead of a string/object should be warned. Their code will still work since they can send a function filter to
requestServerInteraction
and expect the function they've sent inonRequest
and use it as they wish, but we should advise against this. That is because if they don't pass in a function when callingrequestServerInteraction
or QTable triggers@request
itself, they will receive QTable'sfilter
prop, which can be string/object/undefined.The PR fulfills these requirements:
dev
branch (orv[X]
branch)Other information:
In the past, I have made some investigations about the type and had a discussion with @rstoenescu:
ab3708d
(#11347)But, yesterday, someone from the community posted this problem. After some investigation and discussion today, I am pretty confident that JSON API and docs examples are wrong. I created this PR to fix&clarify this problem.
@metalsadman also tagging you here since we had a brief discussion about this on our Discord server.