Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lang): update NL translation for expand/collapse #14499

Merged
merged 2 commits into from Sep 27, 2022

Conversation

Evertvdw
Copy link
Contributor

Small translation fix for NL language

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

@Evertvdw
Copy link
Contributor Author

@rstoenescu I did not check the dutch translation in the previous PR but it turned out the translations were kinda funny currently. Here is a better translation.

@pdanpdan
Copy link
Collaborator

For Qv2 please change the .mjs files, and after this run a yarn build / npm run build in the ui
Changes to the .js files will be lost
Also please also make a PR for Qv1 (there edit the .js files :) )

@Evertvdw
Copy link
Contributor Author

@pdanpdan Done! #14500

@pdanpdan
Copy link
Collaborator

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants